-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ltss to all sles15sp5 support image testsuites' autoyast profiles #21143
Add ltss to all sles15sp5 support image testsuites' autoyast profiles #21143
Conversation
78181a5
to
96b62ec
Compare
Just found some sles15sp6 testsuites are using the sles15sp5 testsuites' autoyast profiles, need to make a copy for SLES15SP6. So add [WIP] here. |
Add ltss to all sles15sp5 support image testsuites' autoyast profiles.
96b62ec
to
ee86033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
there is a lot of duplication of files, would be better to convert them to templates and then do an |
So do you suggest to use |
I'm ok with both, but if doesn't cost too much, I would not duplicate files. |
I think it is ok for current design that each service pack has different profile, since not only the difference for ltss but also other modules (dropped or added) and patterns, etc. between service packs. Later maybe think a better template to cover all SPs. :) |
yes, that is the general case, but for this specific case, seems that the package/pattern didn't change, only what was added for ltss, could you please confirm that @chcao ? SP7 is a refresh version so it is not expected so many changes. But anyway if it is like that, that was the only change, still I'm fine if SM creates a ticket to work on this later and merge this now. If more than that change was needed, then no need for a ticket. |
Both with current design and add |
Discussed with Lemon, he would file a ticket to create a better template to cover all SPs, the changes would cover the duplicated profiles in this PR, so I don't need to update this PR any more. |
Created ticket https://progress.opensuse.org/issues/177009 |
Add ltss to all sles15sp5 support image testsuites' autoyast profiles.