Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ltss to all sles15sp5 support image testsuites' autoyast profiles #21143

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

chcao
Copy link
Contributor

@chcao chcao commented Feb 7, 2025

Add ltss to all sles15sp5 support image testsuites' autoyast profiles.

@chcao chcao force-pushed the add_ltss_to_sles15sp5_ay_profiles branch from 78181a5 to 96b62ec Compare February 7, 2025 11:01
@chcao chcao changed the title [WIP] Add ltss to all sles15sp5 support image testsuites' autoyast profiles Add ltss to all sles15sp5 support image testsuites' autoyast profiles Feb 7, 2025
@chcao chcao requested a review from jknphy February 7, 2025 11:24
@chcao chcao added the qe-yam label Feb 7, 2025
@chcao chcao changed the title Add ltss to all sles15sp5 support image testsuites' autoyast profiles [WIP] Add ltss to all sles15sp5 support image testsuites' autoyast profiles Feb 7, 2025
@chcao
Copy link
Contributor Author

chcao commented Feb 7, 2025

Just found some sles15sp6 testsuites are using the sles15sp5 testsuites' autoyast profiles, need to make a copy for SLES15SP6. So add [WIP] here.

Add ltss to all sles15sp5 support image testsuites' autoyast profiles.
@chcao chcao force-pushed the add_ltss_to_sles15sp5_ay_profiles branch from 96b62ec to ee86033 Compare February 7, 2025 11:41
@chcao chcao changed the title [WIP] Add ltss to all sles15sp5 support image testsuites' autoyast profiles Add ltss to all sles15sp5 support image testsuites' autoyast profiles Feb 7, 2025
Copy link
Contributor

@rakoenig rakoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jknphy
Copy link
Contributor

jknphy commented Feb 11, 2025

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

@chcao
Copy link
Contributor Author

chcao commented Feb 11, 2025

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

So do you suggest to use if for this ticket?

@jknphy
Copy link
Contributor

jknphy commented Feb 11, 2025

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

So do you suggest to use if for this ticket?

I'm ok with both, but if doesn't cost too much, I would not duplicate files.

@lemon-suse
Copy link
Contributor

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

I think it is ok for current design that each service pack has different profile, since not only the difference for ltss but also other modules (dropped or added) and patterns, etc. between service packs. Later maybe think a better template to cover all SPs. :)

@jknphy
Copy link
Contributor

jknphy commented Feb 12, 2025

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

I think it is ok for current design that each service pack has different profile, since not only the difference for ltss but also other modules (dropped or added) and patterns, etc. between service packs. Later maybe think a better template to cover all SPs. :)

yes, that is the general case, but for this specific case, seems that the package/pattern didn't change, only what was added for ltss, could you please confirm that @chcao ?

SP7 is a refresh version so it is not expected so many changes. But anyway if it is like that, that was the only change, still I'm fine if SM creates a ticket to work on this later and merge this now. If more than that change was needed, then no need for a ticket.

@chcao
Copy link
Contributor Author

chcao commented Feb 12, 2025

there is a lot of duplication of files, would be better to convert them to templates and then do an if in the section for ltss, but at this point I guess it should be ok like this ... just take into account for the future that when you need to create so many similar files, something is wrong.

I think it is ok for current design that each service pack has different profile, since not only the difference for ltss but also other modules (dropped or added) and patterns, etc. between service packs. Later maybe think a better template to cover all SPs. :)

yes, that is the general case, but for this specific case, seems that the package/pattern didn't change, only what was added for ltss, could you please confirm that @chcao ?

SP7 is a refresh version so it is not expected so many changes. But anyway if it is like that, that was the only change, still I'm fine if SM creates a ticket to work on this later and merge this now. If more than that change was needed, then no need for a ticket.

Both with current design and add if for ltss are fine for me. From the point of view SP differences, we didn't see any differences between 15sp5 and 15sp6 so far, and we made the profile as short as we can just in case of any differences among SP installations. If we would add a better template to cover all SPs, we could start from these profiles by using if for modules registration. I will update this PR.

@chcao
Copy link
Contributor Author

chcao commented Feb 12, 2025

Both with current design and add if for ltss are fine for me. From the point of view SP differences, we didn't see any differences between 15sp5 and 15sp6 so far, and we made the profile as short as we can just in case of any differences among SP installations. If we would add a better template to cover all SPs, we could start from these profiles by using if for modules registration. I will update this PR.

Discussed with Lemon, he would file a ticket to create a better template to cover all SPs, the changes would cover the duplicated profiles in this PR, so I don't need to update this PR any more.

@jknphy jknphy merged commit 4e2abec into os-autoinst:master Feb 12, 2025
10 checks passed
@lemon-suse
Copy link
Contributor

Created ticket https://progress.opensuse.org/issues/177009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants